[webkit-reviews] review denied: [Bug 100675] [chromium] Provide WebKit API interface for platform gesture curves : [Attachment 171461] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 100675: [chromium] Provide WebKit API interface for platform gesture curves
https://bugs.webkit.org/show_bug.cgi?id=100675

Attachment 171461: Patch
https://bugs.webkit.org/attachment.cgi?id=171461&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171461&action=review


This looks very similar to WebFlingAnimator.  Did you consider consolidating?

> Source/Platform/chromium/public/WebGestureCurveTarget.h:35
> +    // FIXME: add interfaces for scroll(), etc.

I don't understand this FIXME. What other interfaces would you need?

> Source/WebKit/chromium/public/platform/WebGestureCurve.h:1
> +/*

Why are you adding this header?

> Source/WebKit/chromium/public/platform/WebGestureCurveTarget.h:1
> +/*

Why this header?

> Source/WebKit/chromium/src/WebActiveGestureAnimation.cpp:33
> +#if PLATFORM(CHROMIUM)

You're in a directory called .../chromium/..., the PLATFORM(CHROMIUM) check is
redundant

> Source/WebKit/chromium/src/WebActiveGestureAnimation.cpp:51
> +#if PLATFORM(CHROMIUM)

ditto

> Source/WebKit/chromium/src/WebActiveGestureAnimation.h:46
> +    static PassOwnPtr<WebActiveGestureAnimation>
create(PassOwnPtr<WebGestureCurve>, WebGestureCurveTarget*);
> +    static PassOwnPtr<WebActiveGestureAnimation>
create(PassOwnPtr<WebGestureCurve>, WebGestureCurveTarget*, double startTime);

WebKit style would be to just have one function with a default parameter
instead of two