[webkit-reviews] review granted: [Bug 26397] Changing position:relative to position:static results in mis-positioned div : [Attachment 170673] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 30 12:21:03 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 26397: Changing position:relative to position:static results in
mis-positioned div
https://bugs.webkit.org/show_bug.cgi?id=26397
Attachment 170673: Patch
https://bugs.webkit.org/attachment.cgi?id=170673&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170673&action=review
Looks great! Thanks.
>
LayoutTests/fast/block/abspos-child-container-changes-from-relative-to-static-e
xpected.html:3
> +<style type="text/css">
Nit: don't need the type attribute.
>
LayoutTests/fast/block/abspos-child-container-changes-from-relative-to-static-e
xpected.html:6
> + margin-left: 100px;
> + width: 400px;
Nit: indent is off.
>
LayoutTests/fast/block/abspos-child-container-changes-from-relative-to-static-e
xpected.html:37
> + <div id="inner"></div>
Nit: indent is off.
>
LayoutTests/fast/block/abspos-child-container-changes-from-relative-to-static.h
tml:3
> +<style type="text/css">
ditto
>
LayoutTests/fast/block/abspos-child-container-changes-from-relative-to-static.h
tml:6
> + margin-left: 100px;
> + width: 400px;
ditto
>
LayoutTests/fast/block/abspos-child-container-changes-from-relative-to-static.h
tml:38
> + <div id="inner"></div>
ditto
>
LayoutTests/fast/block/abspos-child-container-changes-from-relative-to-static.h
tml:40
> + <script type="text/javascript">
nit: don't need the type attribute
More information about the webkit-reviews
mailing list