[webkit-reviews] review denied: [Bug 100317] Change PopupMenu positioning on Windows such that behaviour on multiple monitors matches Windows standards. : [Attachment 170749] revised patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 100317: Change PopupMenu positioning on Windows such that behaviour on
multiple monitors matches Windows standards.
https://bugs.webkit.org/show_bug.cgi?id=100317

Attachment 170749: revised patch
https://bugs.webkit.org/attachment.cgi?id=170749&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170749&action=review


> Source/WebCore/platform/win/PopupMenuWin.cpp:694
> +FloatRect PopupMenuWin::monitorFromHwnd(HWND hwnd)
> +{
> +    HMONITOR monitor = MonitorFromWindow(hwnd, MONITOR_DEFAULTTOPRIMARY);
> +    MONITORINFOEX monitorInfo;
> +    monitorInfo.cbSize = sizeof(MONITORINFOEX);
> +    GetMonitorInfo(monitor, &monitorInfo);
> +    return monitorInfo.rcWork;
> +}

This can just be a static function, no need to be a member function.