[webkit-reviews] review denied: [Bug 100219] [WK2][WTR] Text input controller needs firstRectForCharacterRange implementation : [Attachment 171459] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 10:25:58 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has denied Mariusz Grzegorczyk
<mariusz.g at samsung.com>'s request for review:
Bug 100219: [WK2][WTR] Text input controller needs firstRectForCharacterRange
implementation
https://bugs.webkit.org/show_bug.cgi?id=100219

Attachment 171459: patch
https://bugs.webkit.org/attachment.cgi?id=171459&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I do not think that this is the right approach. the goal here is to test API on
UI process side. If you add a separate implementation just for testing, and
then break the one in WebPageProxy, the regression test won't notice that.


More information about the webkit-reviews mailing list