[webkit-reviews] review granted: [Bug 100678] [WTR] WebKitTestRunner is not cleaning up the icon database : [Attachment 171426] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 06:36:23 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted  review:
Bug 100678: [WTR] WebKitTestRunner is not cleaning up the icon database
https://bugs.webkit.org/show_bug.cgi?id=100678

Attachment 171426: Patch
https://bugs.webkit.org/attachment.cgi?id=171426&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171426&action=review


r=me then

> Tools/WebKitTestRunner/TestController.cpp:328
> +#if OS(WINDOWS)

Add a comment why not using pathByAppending...


More information about the webkit-reviews mailing list