[webkit-reviews] review denied: [Bug 99830] Web Inspector: Show aggregated time between corresponding time/timeEnd records. : [Attachment 171429] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 05:58:23 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 99830: Web Inspector: Show aggregated time between corresponding
time/timeEnd records.
https://bugs.webkit.org/show_bug.cgi?id=99830

Attachment 171429: Patch
https://bugs.webkit.org/attachment.cgi?id=171429&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171429&action=review


> Source/WebCore/inspector/front-end/TimelinePanel.js:556
> +	       this._innerAddRecordToTimeline(records[i]);

Please extract this into a separate change.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1025
>
+WebInspector.TimelinePresentationModel._calculateAggregatedStatsBetweenRecords
= function(head, tail)

I still don't understand why this code is different from computing cpu time.
They should be combined.


More information about the webkit-reviews mailing list