[webkit-reviews] review denied: [Bug 100678] [WTR] WebKitTestRunner is not cleaning up the icon database : [Attachment 171426] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Thiago Marcos P.
Santos <tmpsantos at gmail.com>'s request for review:
Bug 100678: [WTR] WebKitTestRunner is not cleaning up the icon database
https://bugs.webkit.org/show_bug.cgi?id=100678

Attachment 171426: Patch
https://bugs.webkit.org/attachment.cgi?id=171426&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171426&action=review


> Tools/WebKitTestRunner/TestController.cpp:334
> +#if OS(WINDOWS)
> +	   const char separator = '\\';
> +#else
> +	   const char separator = '/';
> +#endif
> +	   iconDatabaseFileTemp = iconDatabaseFileTemp + separator +
"WebpageIcons.db";
> +	   WKRetainPtr<WKStringRef> iconDatabaseFileTempWK =
WKStringCreateWithUTF8CString(iconDatabaseFileTemp.c_str());

Really? WebCore has methods for doing these things, look in FileSystem.h