[webkit-reviews] review denied: [Bug 99830] Web Inspector: Show aggregated time between corresponding time/timeEnd records. : [Attachment 170163] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 99830: Web Inspector: Show aggregated time between corresponding
time/timeEnd records.
https://bugs.webkit.org/show_bug.cgi?id=99830

Attachment 170163: Patch
https://bugs.webkit.org/attachment.cgi?id=170163&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170163&action=review


> Source/WebCore/inspector/front-end/TimelinePanel.js:556
> +	       this._innerAddRecordToTimeline(records[i]);

Is this change related?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:615
> +    get topLevelRecord()

Please use methods (isTopLevelRecord) instead of getters for better
compile-ability. Also, this seems to be slow, you might want to reflect it in
the name.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:775
>	       contentHelper._appendTextRow(WebInspector.UIString("Self Time"),
Number.secondsToString(this._selfTime, true));

Why is time excluded? Does this belong to this change?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1014
>
+WebInspector.TimelinePresentationModel._calculateAggregatedStatsBetweenRecords
= function(head, tail)

I thought we already aggregated the time for the CPU summary. Why do we need
separate code for that?