[webkit-reviews] review granted: [Bug 99941] Web Inspector: Pipe requests through to Inspector in order to add "initiator" links to messages. : [Attachment 171210] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 04:39:51 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted  review:
Bug 99941: Web Inspector: Pipe requests through to Inspector in order to add
"initiator" links to messages.
https://bugs.webkit.org/show_bug.cgi?id=99941

Attachment 171210: Patch
https://bugs.webkit.org/attachment.cgi?id=171210&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171210&action=review


> Source/WebCore/inspector/InspectorConsoleAgent.cpp:159
> +    String requestId = requestIdentifier ?
IdentifiersFactory::requestId(requestIdentifier) : String();

You don't need it anymore?

> Source/WebCore/inspector/InspectorConsoleAgent.cpp:167
> +    String requestId = requestIdentifier ?
IdentifiersFactory::requestId(requestIdentifier) : String();

ditto


More information about the webkit-reviews mailing list