[webkit-reviews] review granted: [Bug 100742] [subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel snap : [Attachment 171416] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 100742: [subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded
to not pixel snap
https://bugs.webkit.org/show_bug.cgi?id=100742

Attachment 171416: Patch
https://bugs.webkit.org/attachment.cgi?id=171416&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171416&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:-103
> -#else
> -    bool fitsOnLine() const { return currentWidth() <= m_availableWidth; }
> -    bool fitsOnLine(float extra) const { return currentWidth() + extra <=
m_availableWidth; }
> -#endif

Good catch.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:175
> -	   float newLeft = m_block->pixelSnappedLogicalRightForFloat(newFloat);

> +	   float newLeft = m_block->logicalRightForFloat(newFloat);

Good to see more of these pixel snappings becoming unnecessary.