[webkit-reviews] review granted: [Bug 98989] [CSS Shaders] Add CustomFilterRenderer to reuse this class by Accelerated Compositing. : [Attachment 170249] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 98989: [CSS Shaders] Add CustomFilterRenderer to reuse this class by
Accelerated Compositing.
https://bugs.webkit.org/show_bug.cgi?id=98989

Attachment 170249: Patch
https://bugs.webkit.org/attachment.cgi?id=170249&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170249&action=review


This looks great. Just two very minor nits. Sorry this means another submission
- you'll hopefully be getting commit access very soon :)

> Source/WebCore/ChangeLog:10
> +	   rendering css shaders to CustomFilterRenderer.

Super Nit "css" -> "CSS"

> Source/WebCore/platform/graphics/filters/CustomFilterRenderer.cpp:196
> +	   // The viewport is a box with the size of 1 unit, so we are scalling
up here to make sure that translations happen using real pixel

Typo "scaling"