[webkit-reviews] review granted: [Bug 100428] Teach RenderTable how to use Vector::insert and Vector::append instead of its own custom memmove code : [Attachment 171067] Update per Julien's suggestions

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 100428: Teach RenderTable how to use Vector::insert and Vector::append
instead of its own custom memmove code
https://bugs.webkit.org/show_bug.cgi?id=100428

Attachment 171067: Update per Julien's suggestions
https://bugs.webkit.org/attachment.cgi?id=171067&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171067&action=review


> Source/WebCore/rendering/RenderTable.cpp:722
> +    // Save off the index of the new column for use in notifying the
sections of this new column.

I don't think this comment adds much.

> Source/WebCore/rendering/RenderTable.h:132
> +	   explicit ColumnStruct(unsigned initialSpan = 1)

Too bad for the initial value but that's another battle. Thanks for explaining
why it is needed.