[webkit-reviews] review granted: [Bug 100558] [CSS Shaders] Add the ValidatedCustomFilterOperation class : [Attachment 171034] Patch V2

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 100558: [CSS Shaders] Add the ValidatedCustomFilterOperation class
https://bugs.webkit.org/show_bug.cgi?id=100558

Attachment 171034: Patch V2
https://bugs.webkit.org/attachment.cgi?id=171034&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171034&action=review


> Source/WebCore/platform/graphics/filters/ValidatedCustomFilterOperation.h:60
> +    virtual bool operator==(const FilterOperation& o) const
> +    {
> +	   if (!isSameType(o))
> +	       return false;
> +
> +	   return true;
> +    }

While this is unimportant, I think we should return false while this remains
unimplemented. I'm happy for you to ignore me here.