[webkit-reviews] review denied: [Bug 96597] Float block's logical top margin is illegal in vertical writing mode. : [Attachment 164050] Rebase

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 96597: Float block's logical top margin is illegal in vertical writing
mode.
https://bugs.webkit.org/show_bug.cgi?id=96597

Attachment 164050: Rebase
https://bugs.webkit.org/attachment.cgi?id=164050&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=164050&action=review


Looks good. Please adress my nitpicky comment.

> Source/WebCore/ChangeLog:8
> +	   Float block's logical top margin is illegal in vertical writing
mode.

Please don't repeat this.

> LayoutTests/ChangeLog:9
> +	   This test's block should be at the center of black border

This explanation should be in the test so that test is more readable.