[webkit-reviews] review granted: [Bug 100552] Regression(r132647) - enable Webgl in EwkView : [Attachment 171055] enable webgl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 02:56:42 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted kalyan
<kondapallykalyan at gmail.com>'s request for review:
Bug 100552: Regression(r132647) - enable Webgl in EwkView
https://bugs.webkit.org/show_bug.cgi?id=100552

Attachment 171055: enable webgl
https://bugs.webkit.org/attachment.cgi?id=171055&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171055&action=review


> Source/WebKit2/ChangeLog:8
> +	   WebGL is enabled with the following changeset:
http://trac.webkit.org/changeset/132627 .

I would just remove the .

> Source/WebKit2/ChangeLog:10
> +	   But some of the changes are lost after the following changeset:
http://trac.webkit.org/changeset/132647 .
> +	   i.e setWebGLEnabled(true);  in EwkViewImpl.cpp Bringing back the
change.

Bringing... seems like a new sentence.


More information about the webkit-reviews mailing list