[webkit-reviews] review denied: [Bug 94313] [GTK] Enable introspection for webkit2 : [Attachment 159047] Enable webkit2 introspection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 02:34:42 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> has denied  review:
Bug 94313: [GTK] Enable introspection for webkit2
https://bugs.webkit.org/show_bug.cgi?id=94313

Attachment 159047: Enable webkit2 introspection
https://bugs.webkit.org/attachment.cgi?id=159047&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159047&action=review


Thanks for the patch, and sorry for the late review. Patches in WebKit require
a ChangeLog entry, and you should set the review flag to ? to ask for a review.
See http://www.webkit.org/coding/contributing.html

> Source/WebKit2/GNUmakefile.am:211
> +	     --include=Gtk- at GTK_API_VERSION@ \

WebKit2 depends unconditionally on GTK 3, so we don't need to use the
GTK_API_VERSION


More information about the webkit-reviews mailing list