[webkit-reviews] review granted: [Bug 100708] [WK2] Add a NetworkingContext for NetworkProcess : [Attachment 171331] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 29 16:14:11 PDT 2012


Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 100708: [WK2] Add a NetworkingContext for NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=100708

Attachment 171331: proposed patch
https://bugs.webkit.org/attachment.cgi?id=171331&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171331&action=review


> Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h:43
> +    virtual bool isValid() const;
> +
> +    virtual bool needsSiteSpecificQuirks() const;
> +    virtual bool localFileContentSniffingEnabled() const;
> +    virtual WebCore::SchedulePairHashSet* scheduledRunLoopPairs() const;
> +    virtual WebCore::ResourceError blockedError(const
WebCore::ResourceRequest&) const;

These should all be marked OVERRIDE.


More information about the webkit-reviews mailing list