[webkit-reviews] review granted: [Bug 100306] Add non-virtual firstChild/lastChild overrides to RenderBlock and RenderTableCol for a > 30% speedup on table from bug 100304 : [Attachment 170518] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 100306: Add non-virtual firstChild/lastChild overrides to RenderBlock and
RenderTableCol for a > 30% speedup on table from bug 100304
https://bugs.webkit.org/show_bug.cgi?id=100306

Attachment 170518: Patch
https://bugs.webkit.org/attachment.cgi?id=170518&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170518&action=review


> Source/WebCore/rendering/RenderBlock.h:89
> +    RenderObject* firstChild() const { ASSERT(children() ==
virtualChildren()); return children()->firstChild(); }

Probably add a comment here so that someone does not remove them in future
without understanding the loss. Also, this function will look a little better 2
lines below after children() function definition. The assert is pretty useless
i think since virtualChildren is just used to reference from RenderObject, i
dont think there can be a case where children() != virtualChildren()

>> Source/WebCore/rendering/RenderObject.h:184
>> +	// functions to make these fast when we already have a more specific
poitner type.
> 
> typo: poitner

typo: poitner