[webkit-reviews] review granted: [Bug 100701] AtomicString(CFStringRef) shouldn't unconditionally create a StringImpl : [Attachment 171322] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 29 15:41:21 PDT 2012


mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 100701: AtomicString(CFStringRef) shouldn't unconditionally create a
StringImpl
https://bugs.webkit.org/show_bug.cgi?id=100701

Attachment 171322: Patch
https://bugs.webkit.org/attachment.cgi?id=171322&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171322&action=review


> Source/WebCore/ChangeLog:9
> +	   Add __ZN3WTF12AtomicString3addEPK10__CFString.

You can use the demangled name here.

> Source/WebCore/platform/text/cf/AtomicStringCF.cpp:2
> + * Copyright (C) 2010, 2011, 2012 Apple Inc. All rights reserved.

I think this is all from 2012.


More information about the webkit-reviews mailing list