[webkit-reviews] review denied: [Bug 99083] [chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents : [Attachment 170933] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 99083: [chromium] Pass canPaintLCDText to
WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083

Attachment 170933: Patch
https://bugs.webkit.org/attachment.cgi?id=170933&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170933&action=review


I believe this will completely break aura - you should test that.

To land an API change like this, what you probably should do is either add a
#define guard for the signature change and land chromium-side code first that
checks for the #define and adjusts accordingly.  After the patch lands you can
remove the guards from chromium code and then remove the #define from the
WebKit header (although this step is often neglected, as you can tell from the
#define WEBCONTENTLAYERCLIENT_HAS_OPAQUE / _FLOAT_OPAQUE_RECT #defines in
WCLC.h).

R- since this will probably break chromeos completely.	Otherwise, looks fine.

> Source/Platform/chromium/public/WebContentLayerClient.h:48
> +    // FIXME: Remove this version of paintContents after chromium starts
using the
> +    // new version with canPaintLCDText.
> +    void paintContents(WebCanvas* canvas, const WebRect& clip, WebFloatRect&
opaque)

Did you see the WebContentLayerClient override in ui/compositor/layer.h in the
chromium tree?	This change won't work for that