[webkit-reviews] review granted: [Bug 100690] Support captions when PLUGIN_PROXY_FOR_VIDEO : [Attachment 171289] Proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 100690: Support captions when PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=100690

Attachment 171289: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=171289&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171289&action=review


> Source/WebCore/rendering/RenderEmbeddedObject.cpp:258
> +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
> +    RenderBox* controlsRenderer = toRenderBox(m_children.firstChild());

I think it would be good to have a comment here pointing out that this code is
duplicated from RenderVideo (or maybe even share code).