[webkit-reviews] review denied: [Bug 100378] [BlackBerry] Implement MediaPlayerPrivate::didLoadingProgress for BlackBerry Media Player : [Attachment 171251] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied John Griggs <jgriggs at rim.com>'s request
for review:
Bug 100378: [BlackBerry] Implement MediaPlayerPrivate::didLoadingProgress for
BlackBerry Media Player
https://bugs.webkit.org/show_bug.cgi?id=100378

Attachment 171251: Patch
https://bugs.webkit.org/attachment.cgi?id=171251&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171251&action=review


Looks good in general, some small issues to fix.

> Source/WebCore/ChangeLog:16
> +		   (MediaPlayerPrivate):

Please fix indenting here, look at other entries.

> LayoutTests/ChangeLog:13
> +	   *
platform/blackberry/media/progress-events-generated-correctly.html: Added.

Ditto.

>
LayoutTests/platform/blackberry/media/progress-events-generated-correctly.html:
30
> +	       //consoleWrite("EVENT(progress): " + progressCount);

We don't want commented code. If you don't want this, better remove the line.

>
LayoutTests/platform/blackberry/media/progress-events-generated-correctly.html:
35
> +	       //consoleWrite("EVENT(ended): " + progressCount);

Ditto.