[webkit-reviews] review granted: [Bug 100662] [EFL][WK2] Fix cursor change detection in EwkViewImpl::setCursor() : [Attachment 171218] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 100662: [EFL][WK2] Fix cursor change detection in EwkViewImpl::setCursor()
https://bugs.webkit.org/show_bug.cgi?id=100662

Attachment 171218: Patch
https://bugs.webkit.org/attachment.cgi?id=171218&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171218&action=review


Is it possible to test this using a unit test?

> Source/WebKit2/ChangeLog:13
> +	   Cursor change detection in EwkViewImpl::setCursor() relies on
> +	   addresses returned by Cursor::platformCursor(). However, the
> +	   value returned is currently assigned to a WKEinaSharedString
> +	   instead of a raw pointer. Therefore, the address is always
> +	   different and we keep recreating Evas Objects for the same
> +	   cursor.

Yikes :-)