[webkit-reviews] review granted: [Bug 100530] Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers : [Attachment 170942] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 29 00:02:56 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 100530: Web Inspector: Timeline: make cpu-monitoring feature available only
on capable browsers
https://bugs.webkit.org/show_bug.cgi?id=100530

Attachment 170942: Patch
https://bugs.webkit.org/attachment.cgi?id=170942&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170942&action=review


> Source/WebCore/inspector/InspectorClient.h:60
> +    virtual bool supportsMainThreadMonitoring() { return false; }

Please rename it to canMainThreadMonitoring for consistency with other similar
methods on the client.


More information about the webkit-reviews mailing list