[webkit-reviews] review granted: [Bug 99228] The shadow element is not reprojected to a nested shadowRoot : [Attachment 170807] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 28 20:56:24 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 99228: The shadow element is not reprojected to a nested shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=99228

Attachment 170807: Patch
https://bugs.webkit.org/attachment.cgi?id=170807&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170807&action=review


> Source/WebCore/dom/ElementShadow.cpp:135
>  InsertionPoint* ElementShadow::insertionPointFor(const Node* node) const

That method got whittled away to nothing! Can probably remove it.

> Source/WebCore/html/shadow/InsertionPoint.h:135
> +inline Element* parentElementForDistribution(const Node* node)

Is this guy still being used somewhere?


More information about the webkit-reviews mailing list