[webkit-reviews] review granted: [Bug 94886] Add an optimized version of copyLCharsFromUCharSource for ARM : [Attachment 160481] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 94886: Add an optimized version of copyLCharsFromUCharSource for ARM
https://bugs.webkit.org/show_bug.cgi?id=94886

Attachment 160481: Patch
https://bugs.webkit.org/attachment.cgi?id=160481&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160481&action=review


This looks awesome, didn't know about the interleaved unpack, that's really
handy.

> Source/WTF/wtf/text/ASCIIFastPath.h:134
> +#elif COMPILER(GCC) && CPU(ARM_NEON) && !(PLATFORM(BIG_ENDIAN) ||
PLATFORM(MIDDLE_ENDIAN))

Your optimized path skips an ASSERT to check the upper bits are zero; might be
worth adding "&& defined(NDEBUG)" so that debug builds get the C-loop with the
ASSERT.

> Source/WTF/wtf/text/ASCIIFastPath.h:141
> +	   do {

I think WebKit coding style is no parens here.