[webkit-reviews] review granted: [Bug 100567] Allow :before and :after on radio buttons and checkboxes : [Attachment 171039] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 26 16:21:48 PDT 2012
Eric Seidel <eric at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 100567: Allow :before and :after on radio buttons and checkboxes
https://bugs.webkit.org/show_bug.cgi?id=100567
Attachment 171039: Patch
https://bugs.webkit.org/attachment.cgi?id=171039&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171039&action=review
LGTM besides the ChangeLog typo.
> Source/WebCore/ChangeLog:19
> + No new tests, it's really hard to test what generated content looks
like
> + on a form control without using a pixel test, and I don't think
generating
> + tons of baselines right now is worth it for this hack.
:)
More information about the webkit-reviews
mailing list