[webkit-reviews] review denied: [Bug 100552] Regression(r132647) - enable Webgl in EwkView : [Attachment 171019] enable webgl
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 26 15:58:26 PDT 2012
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied kalyan
<kondapallykalyan at gmail.com>'s request for review:
Bug 100552: Regression(r132647) - enable Webgl in EwkView
https://bugs.webkit.org/show_bug.cgi?id=100552
Attachment 171019: enable webgl
https://bugs.webkit.org/attachment.cgi?id=171019&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171019&action=review
> Source/WebKit2/ChangeLog:8
> + Webgl is enabled with http://trac.webkit.org/changeset/132627.
WebGL*
> Source/WebKit2/ChangeLog:9
> + But some of the changes seem lost after
http://trac.webkit.org/changeset/132647.
seems is a bit vague, you need to make us confident of your change
>> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:128
>> + //Enable Webgl Support
>
> Should have a space between // and comment [whitespace/comments] [4]
This comments should be actual sentences. Ie. a space after // and a
punctuation mark at the end. In this case the comment doesn't add any value, so
it should be removed
More information about the webkit-reviews
mailing list