[webkit-reviews] review granted: [Bug 100128] [Chromium] Convert Chromium template string to an LDML date format : [Attachment 170785] Patch 2

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 100128: [Chromium] Convert Chromium template string to an LDML date format
https://bugs.webkit.org/show_bug.cgi?id=100128

Attachment 170785: Patch 2
https://bugs.webkit.org/attachment.cgi?id=170785&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170785&action=review


OK

> Source/WebKit/chromium/src/LocalizedStrings.cpp:281
> +    for (unsigned i = 0; i < length; ++i) {
> +	   if (templ[i] == '$' && i + 1 < length && (templ[i + 1] == '1' ||
templ[i + 1] == '2')) {

I think you could just make the loop go to length - 1 and remove the i + 1 <
length check.