[webkit-reviews] review granted: [Bug 100119] Web Inspector: [Styles] Handle non-parsedOk properties as inactive ones : [Attachment 170932] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 100119: Web Inspector: [Styles] Handle non-parsedOk properties as inactive
ones
https://bugs.webkit.org/show_bug.cgi?id=100119

Attachment 170932: Patch
https://bugs.webkit.org/attachment.cgi?id=170932&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170932&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1465
> +		       if (property.inactive || !property.parsedOk ||
section.isPropertyOverloaded(property.name))

I would add not-parsed-ok class to the rule that is setting line-through
decoration instead.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1955
> +	   if (this.property.inactive || !this.parsedOk)

ditto