[webkit-reviews] review granted: [Bug 100523] [Qt] MiniBrowser segfaults on exit after using WebGL. : [Attachment 170927] patch for review.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 100523: [Qt] MiniBrowser segfaults on exit after using WebGL.
https://bugs.webkit.org/show_bug.cgi?id=100523

Attachment 170927: patch for review.
https://bugs.webkit.org/attachment.cgi?id=170927&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170927&action=review


>>> Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:61
>>> +	 Window getXWindow()
>> 
>> OffscreenXWindow? it actually feels more like a create method
> 
> I was thinking about how to name these things properly as well.
> It is a create method, but only for a single instance. So it feels more like
a get to me. (implicit creation)
> OffScreenRootWindow::getOffscreenXWindow() somehow feels very redundant as
well, doesn't it?

You are right. It is fine!