[webkit-reviews] review granted: [Bug 100515] Web Inspector: instrument chromium GlyphCache. It keeps ~2mb. : [Attachment 170921] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 100515: Web Inspector: instrument chromium GlyphCache. It keeps ~2mb.
https://bugs.webkit.org/show_bug.cgi?id=100515

Attachment 170921: Patch
https://bugs.webkit.org/attachment.cgi?id=170921&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170921&action=review


> Source/WebCore/ChangeLog:3
> +	   Web Inspector: instrument chromium GlyphCache. It keeps ~2mb.

~2mb on what page?

> Source/WebCore/ChangeLog:9
> +

Can you add a test for this?

> Source/WebCore/platform/PlatformMemoryInstrumentation.cpp:38
> +MemoryObjectType PlatformMemoryTypes::GlyphCache = "MemoryCache.GlyphCache";


I'd rather use Fonts.GlyphCache instead of MemoryCache.GlyphCache.