[webkit-reviews] review granted: [Bug 100232] [EFL][WK2] Clean up construction/destruction code in Ewk_view : [Attachment 170893] patch v2

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 100232: [EFL][WK2] Clean up construction/destruction code in Ewk_view
https://bugs.webkit.org/show_bug.cgi?id=100232

Attachment 170893: patch v2
https://bugs.webkit.org/attachment.cgi?id=170893&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170893&action=review


> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:111
> +    WebKit::WebPageProxy* page() { return m_pageProxy.get(); }

why remove the inline?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:230
> +    // Note, initialization order is important.

initialization order matters :-) it is not just important

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:249
> +    Evas_GL* m_evasGl;
> +    Evas_GL_Context* m_evasGlContext;
> +    Evas_GL_Surface* m_evasGlSurface;

maybe we should add OwnPtr support for these