[webkit-reviews] review granted: [Bug 100497] Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase : [Attachment 170891] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 26 04:52:12 PDT 2012
Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 100497: Memory instrumentation: report memory occupied by ResourceRequest
instead of its base ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=100497
Attachment 170891: Patch
https://bugs.webkit.org/attachment.cgi?id=170891&action=review
------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170891&action=review
A few textual nits to fix before landing.
> Source/WebCore/ChangeLog:8
> + Added memory reporting method to chromium implementation of
ResourceRequest.
chromium -> Chromium?
> Source/WebCore/ChangeLog:15
> + and shouldn't be used directly(ResourceRequest should be used
instead).
add a space before '('
More information about the webkit-reviews
mailing list