[webkit-reviews] review denied: [Bug 99445] [Qt][WK2] REGRESSION(r131428): cookies.db created on wrong place : [Attachment 170638] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied János Badics
<jbadics at inf.u-szeged.hu>'s request for review:
Bug 99445: [Qt][WK2] REGRESSION(r131428): cookies.db created on wrong place
https://bugs.webkit.org/show_bug.cgi?id=99445

Attachment 170638: proposed patch
https://bugs.webkit.org/attachment.cgi?id=170638&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Yeah, this patch comes from WK2's QtDefaultDataLocation.cpp, the QString
defaultDataLocation() function in particular.

Now we do things like this in various places:

    s_defaultDatabaseDirectory = defaultDataLocation() +
QLatin1String("Databases");

or

    defaultDataLocation() + QLatin1String("WebpageIcons.db");

or (as you spotted) cookieStoragePath + QLatin1String("/cookies.db"); where
cookieStoragePath comes from the same function (through several levels of
indirection).

I suggest to harden defaultDataLocation() instead and at the end of the
function make sure that the path ends with a separator, i.e.

if (!s_dataLocation.endsWith(QDir::separator())
    s_dataLocation.append(QDir::separator());