[webkit-reviews] review denied: [Bug 100460] Refactor calendar picker to remove _x/_y from DaysTable : [Attachment 170830] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 100460: Refactor calendar picker to remove _x/_y from DaysTable
https://bugs.webkit.org/show_bug.cgi?id=100460

Attachment 170830: Patch
https://bugs.webkit.org/attachment.cgi?id=170830&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170830&action=review


> Source/WebCore/ChangeLog:22
> +	   (DaysTable.prototype.selectRangeContainingNode): Selects
date/week/month containing the given day node.
> +	   (DaysTable.prototype.selectRangeAtPosition): Selects date/week/month
at the given position.
> +	   (DaysTable.prototype.firstSelectedNode): Returns first selected day
node.
> +	   (DaysTable.prototype.deselect): Deselects all selections.

Function names should be updated to "_foo"

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1031
> +DaysTable.prototype.firstNodeInSelectedRange = function() {

should be _firstNodeInSelectedRange?

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1037
> +    var selectedNodesLength = selectedNodes.length;

This variable is not used.