[webkit-reviews] review granted: [Bug 100446] local(Helvetica) in src descriptor prevent fallback : [Attachment 170815] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 100446: local(Helvetica) in src descriptor prevent fallback
https://bugs.webkit.org/show_bug.cgi?id=100446

Attachment 170815: Patch
https://bugs.webkit.org/attachment.cgi?id=170815&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170815&action=review


> Source/WebCore/ChangeLog:19
> +

Somewhere in this change log there should be a description of the problem and
how it was solved. Something along these lines, perhaps:
FontCache::getCachedFontData() has a mechanism that aliases a few pairs of font
family names, so that if the family name specified in the font-family property
is not available on the system, but the its alias is available, it will be used
instead. This is appropriate for the font-family property, but not for font
family names specified in the local() function of the src descriptor in a
@font-face rule.

> Source/WebCore/css/CSSFontFaceSource.cpp:109
> +	   return fontCache()->getCachedFontData(fontDescription, m_string,
true);

You can even add a comment before this line explaining why we’re passing true.