[webkit-reviews] review granted: [Bug 98465] IndexedDB: Add histogram statistics for backing store errors : [Attachment 170725] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 15:22:22 PDT 2012


Adam Barth <abarth at webkit.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 98465: IndexedDB: Add histogram statistics for backing store errors
https://bugs.webkit.org/show_bug.cgi?id=98465

Attachment 170725: Patch
https://bugs.webkit.org/attachment.cgi?id=170725&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170725&action=review


> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:484
> -    return transaction->commit();
> +    if (!transaction->commit()) {
> +    }
> +    return true;

This looks a bit strange.  Is there a typo here?


More information about the webkit-reviews mailing list