[webkit-reviews] review denied: [Bug 100378] [BlackBerry] Implement MediaPlayerPrivate::didLoadingProgress for BlackBerry Media Player : [Attachment 170695] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied John Griggs <jgriggs at rim.com>'s request
for review:
Bug 100378: [BlackBerry] Implement MediaPlayerPrivate::didLoadingProgress for
BlackBerry Media Player
https://bugs.webkit.org/show_bug.cgi?id=100378

Attachment 170695: Patch
https://bugs.webkit.org/attachment.cgi?id=170695&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170695&action=review


Generally looks good, some details we need to sort out still.

> Source/WebCore/ChangeLog:3
> +	   2012-10-25  John Griggs  <jgriggs at rim.com>

The ChangeLog needs some cleaning up. Basically it should match the layout of
the other entries.

>
Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:176
> +    mutable float m_lastLoadingTime;

I am not convinced mutalble is needed here, please try without it.