[webkit-reviews] review granted: [Bug 100358] [V8] Add histograms to measure V8 work done during window close and navigation : [Attachment 170713] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 12:36:27 PDT 2012


Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 100358: [V8] Add histograms to measure V8 work done during window close and
navigation
https://bugs.webkit.org/show_bug.cgi?id=100358

Attachment 170713: Patch
https://bugs.webkit.org/attachment.cgi?id=170713&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170713&action=review


> Source/WebCore/bindings/v8/ScriptController.cpp:162
> +   
HistogramSupport::histogramCustomCounts("ScriptController::clearForClose",
(currentTime() - start) * 1000, 0, 10000, 50);

We usually use names more like WebCore.ScriptController.ClearForClose for
histograms.


More information about the webkit-reviews mailing list