[webkit-reviews] review denied: [Bug 79173] dragover's default action should prevent drop for file drags : [Attachment 169788] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 12:23:23 PDT 2012


Daniel Cheng <dcheng at chromium.org> has denied  review:
Bug 79173: dragover's default action should prevent drop for file drags
https://bugs.webkit.org/show_bug.cgi?id=79173

Attachment 169788: Patch
https://bugs.webkit.org/attachment.cgi?id=169788&action=review

------- Additional Comments from Daniel Cheng <dcheng at chromium.org>
I'm going to be updating this patch for the following items:
1. Reflect the fact that the layout test I added is only for file drags.
2. Fix the fact that simply cancelling dragover is enough to get a drop event
(per the spec, unless you're the body element, you need to cancel both the
dragenter/dragover event). This brings us in line with the spec and IE
behavior.


More information about the webkit-reviews mailing list