[webkit-reviews] review granted: [Bug 100030] run-perf-tests should have a --repeat option : [Attachment 170691] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 100030: run-perf-tests should have a --repeat option
https://bugs.webkit.org/show_bug.cgi?id=100030

Attachment 170691: Patch
https://bugs.webkit.org/attachment.cgi?id=170691&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170691&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:179
> +		   if self._currentRun == self._totalRuns:

Nit: I'd pull this out of the while loop and into a separate if block.

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:217
> +	   if self._options.show_results:

Seems kinda silly to have if block inside this call, or even to have a separate
function for this at all if it's just two lines ...