[webkit-reviews] review denied: [Bug 100030] run-perf-tests should have a --repeat option : [Attachment 170614] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Mike West <mkwst at chromium.org>'s
request for review:
Bug 100030: run-perf-tests should have a --repeat option
https://bugs.webkit.org/show_bug.cgi?id=100030

Attachment 170614: Patch
https://bugs.webkit.org/attachment.cgi?id=170614&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170614&action=review


Just a couple of minor things ...

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71
> +	   self._totalRuns = int(self._options.repeat)

You can set type="int" in make_option() below and avoid this cast.

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:176
> +		   exit_code = self._generate_and_show_results()

I would split this into two routines so that you can merge in the results after
each run but only show the results at the end.