[webkit-reviews] review denied: [Bug 100334] [WK2] Use per destination ID message receivers for WebVibrationProxy. : [Attachment 170610] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 100334: [WK2] Use per destination ID message receivers for
WebVibrationProxy.
https://bugs.webkit.org/show_bug.cgi?id=100334

Attachment 170610: Patch
https://bugs.webkit.org/attachment.cgi?id=170610&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
I don't like this approach. The whole point of introducing named messages and
message receiver maps is so we can get rid of a bunch of #ifdefs and let the
relevant objects themselves be in charge of listening for messages.

WebVibrationProxy objects seem to be per context but they still use page
destination IDs? Maybe they should be per page? If not, I'd recommend not using
the destination ID but instead passing the page ID as an explicit argument to
the messages.