[webkit-reviews] review granted: [Bug 97576] Can't easily position the cursor on an empty line in a textarea with touch if touch adjustment is enabled : [Attachment 169478] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Kevin Ellis
<kevers at chromium.org>'s request for review:
Bug 97576: Can't easily position the cursor on an empty line in a textarea with
touch if touch adjustment is enabled
https://bugs.webkit.org/show_bug.cgi?id=97576

Attachment 169478: Patch
https://bugs.webkit.org/attachment.cgi?id=169478&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169478&action=review


Looks good

>>> Source/WebCore/page/TouchAdjustment.cpp:342
>>> +	 float targetArea = max(rect.size().area(), 1);
>> 
>> Can you explain what this change achieves?
> 
> The change guards against division by zero.  Was seeing some nan scores when
clicking near the beginning of a blank line without the change.

was ´area´ zero or clamped to zero?