[webkit-reviews] review granted: [Bug 100210] [BlackBerry] Support pixel tests for BlackBerry DRT : [Attachment 170605] patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 100210: [BlackBerry] Support pixel tests for BlackBerry DRT
https://bugs.webkit.org/show_bug.cgi?id=100210

Attachment 170605: patch
https://bugs.webkit.org/attachment.cgi?id=170605&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170605&action=review


Looks good, please fix before landing.

> Source/WebKit/ChangeLog:8
> +	   Adds a step to build ImageDiff from Qt for DRT.

In general you probably want to credit Chris Wells, he did most of this patch
AFAIK.

> Tools/DumpRenderTree/blackberry/PNGImageEncoder.cpp:27
> +#endif

Is this block really needed now that you got rid of Skia below?

> Tools/DumpRenderTree/blackberry/build:4
> +# the ~/dev/webplatform/tools/binding_generator folder.

These two lines are not relevant, please remove.