[webkit-reviews] review denied: [Bug 73920] [Qt] Tiled backing store failing to update view under certain conditions : [Attachment 170646] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Lamarque V. Souza
<Lamarque.Souza.ext at basyskom.com>'s request for review:
Bug 73920: [Qt] Tiled backing store failing to update view under certain
conditions
https://bugs.webkit.org/show_bug.cgi?id=73920

Attachment 170646: Patch
https://bugs.webkit.org/attachment.cgi?id=170646&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170646&action=review


> Source/WebCore/page/FrameView.cpp:2026
> +	   frame()->tiledBackingStore()->removeAllTiles();

This feels quite wrong to drop all tiles just because of an issue edge tiles,
the same tiles can be used between pages, and invalidate calls are responsible
of triggering a refresh of the tile contents.
There is a call to tiledBackingStoreContentsRect in
TiledBackingStore::createTiles that should return a different contents size for
the new page. A change of that rect should be responsible of triggering a call
to resizeEdgeTiles. Please check around there to fix your issue.