[webkit-reviews] review denied: [Bug 99628] [BlackBerry] Remove unnecessary assertion in WebPage::executeJavaScript. : [Attachment 169236] patch for 99628.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 07:31:15 PDT 2012


Rob Buis <rwlbuis at gmail.com> has denied Lyon Chen <liachen at rim.com>'s request
for review:
Bug 99628: [BlackBerry] Remove unnecessary assertion in
WebPage::executeJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=99628

Attachment 169236: patch for 99628.
https://bugs.webkit.org/attachment.cgi?id=169236&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
To me it looks like when isUTF8() is true, it really means the internal string
is utf8 encoded, no matter what string it was constructed from. If it is false
it might still be utf8. This assert simply verifies that the String is
guarenteed to be utf8 encoded, which seems fine. So unless we start seeing
problems here, I will r- for now.


More information about the webkit-reviews mailing list