[webkit-reviews] review granted: [Bug 100288] [EFL][WK2][AC] Regression(132392) infinite loop when displaying certain animations. : [Attachment 170628] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Yael
<yael.aharon.m at gmail.com>'s request for review:
Bug 100288: [EFL][WK2][AC] Regression(132392) infinite loop when displaying
certain animations.
https://bugs.webkit.org/show_bug.cgi?id=100288

Attachment 170628: Patch
https://bugs.webkit.org/attachment.cgi?id=170628&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170628&action=review


>>> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:265
>>> +	 }
>> 
>> con't you not just do m_dirtyRects.clear() or so afterward? Is remove really
safe here?
> 
> Since I always take the first item, I think remove is safe here.

Isn't thre a removeFirst() ? anyway this might not be very efficient. Why not
just iterate and call clear() afterward