[webkit-reviews] review granted: [Bug 100249] Add setMediaTypeOverride to window.internals.settings : [Attachment 170590] patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 100249: Add setMediaTypeOverride to window.internals.settings
https://bugs.webkit.org/show_bug.cgi?id=100249

Attachment 170590: patch
https://bugs.webkit.org/attachment.cgi?id=170590&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170590&action=review


>> Source/WebCore/page/Settings.cpp:128
>> +	, m_mediaTypeOverride("screen")
> 
> why not pick the current one? Some ports might change it.

or say someone does this while printing? then it will be 'print'

> Source/WebCore/page/Settings.cpp:484
> +    mainFrame->document()->styleResolverChanged(RecalcStyleImmediately);
> +    view->layout();

I think the setDeviceScaleFactor does this slightly different